GATs outlives lint: Try to prove bounds #91849
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
jackh726
force-pushed
the
gats-outlives-lint-part2
branch
from
ef723b7 to
8be1695
Compare
jackh726
commented
Dec 13, 2021
Comment on lines
+610
to
+611
| // `region_a: region_b` -> `region_b <= region_a` | ||
| (&infcx).push_sub_region_constraint(origin, region_b, region_a); |
There was a problem hiding this comment.
This is separate from the above logic; bug fix for #91036
jackh726
force-pushed
the
gats-outlives-lint-part2
branch
from
8be1695 to
8a28c17
Compare
nikomatsakis
requested changes
Dec 13, 2021
|
r=me with the above changes |
|
@bors r=nikomatsakis |
|
📌 Commit 4897415 has been approved by |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 13, 2021
…r=nikomatsakis GATs outlives lint: Try to prove bounds Fixes rust-lang#91036 Fixes rust-lang#90888 Fixes rust-lang#91348 (better error + documentation to be added to linked issue) Instead of checking for bounds directly, try to prove them in the associated type environment. Also, add a bit of extra information to the error, including a link to the relevant discussion issue (rust-lang#87479). That should be edited to include a brief summary of the current state of the outlives lint, including a brief background. It also might or might not be worth it to bump this to a full error code at some point. r? `@nikomatsakis`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 13, 2021
…askrgr Rollup of 5 pull requests Successful merges: - rust-lang#91699 (Add `-webkit-appearance: none` to search input) - rust-lang#91846 (rustdoc: Reduce number of arguments for `run_test` a bit) - rust-lang#91847 (Fix FIXME for `generic_arg_infer` in `create_substs_for_ast_path`) - rust-lang#91849 (GATs outlives lint: Try to prove bounds) - rust-lang#91855 (Stabilize const_cstr_unchecked) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #91036
Fixes #90888
Fixes #91348 (better error + documentation to be added to linked issue)
Instead of checking for bounds directly, try to prove them in the associated type environment.
Also, add a bit of extra information to the error, including a link to the relevant discussion issue (#87479). That should be edited to include a brief summary of the current state of the outlives lint, including a brief background. It also might or might not be worth it to bump this to a full error code at some point.
r? @nikomatsakis